Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --retry flag to the mise install command to handle transient installation failures such as network issues. The implementation includes automatic retry logic with exponential backoff and proper error handling for retryable errors.
- Adds
--retryflag tomise installandmise install-intocommands - Implements retry logic with exponential backoff for transient errors
- Adds error detection for retryable network-related errors
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cli/install.rs | Adds the --retry CLI flag to the install command |
| src/cli/install_into.rs | Adds the --retry CLI flag to the install-into command |
| src/toolset/mod.rs | Adds retry field to InstallOptions struct and passes it through |
| src/install_context.rs | Adds retry field to InstallContext struct |
| src/backend/mod.rs | Implements the core retry logic with exponential backoff and error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
reitermarkus
force-pushed
the
install-retry
branch
from
967d7c2 to
20304a6
Compare
|
not sure I want this now that we have #6444 |
reitermarkus
force-pushed
the
install-retry
branch
from
20304a6 to
08bdbda
Compare
|
Okay, I missed this since it was not mentioned in the discussion or shows up as a linked PR there. I saw the contributing guide mentions https://github.com/jdx/mise/issues/3859, yet I cannot view it since issues are now completely disabled. What is the reason for not tracking issues as issues which would show up in linked PRs and vice-versa? Quite ironic that opening a discussion first still ended up creating wasted effort. |
|
Sorry for that @reitermarkus, i usually mention the PRs in the discussion which i missed to do. |
|
@roele, no worries. |
Closes #6429.